fix(providers): add iteration cap to performAgentChain to prevent infinite loops#194
Closed
manusjs wants to merge 1 commit intovxcontrol:masterfrom
Closed
fix(providers): add iteration cap to performAgentChain to prevent infinite loops#194manusjs wants to merge 1 commit intovxcontrol:masterfrom
manusjs wants to merge 1 commit intovxcontrol:masterfrom
Conversation
…inite loops Fixes vxcontrol#175 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
hey @manusjs thanks for the PR! these changes have already been addressed via #178, which was selected earlier and merged to master as part of #185, then further refined in #206. i've explained our PR acceptance process in this comment, please refer to it for future contributions. thanks again for identifying and working on this issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a hard iteration cap to
performAgentChainand escalating error behaviour in the repeating-detector to prevent infinite loops when a model repeatedly calls the same tool.Fixes #175
Root Cause
performAgentChaininbackend/pkg/providers/performer.gois an unboundedfor {}loop. When the repeating detector fires it returns(message, nil)— a successful response — sowantToStopis never set and the loop continues. Production logs show 4800+ repeating-detector warnings in a single session.Changes
performer.go: AddedmaxAgentChainIterations = 100cap. Loop returns an error if exceeded.maxRepeatingBeforeAbort = 5) returns an actualerrorinstead of a nil-error message, so the error path inperformAgentChainfires.performer_test.go(new):TestAgentChainIterationCap— mocks a chain that never stops and asserts error is returned aftermaxAgentChainIterations.